Implemented further review comments

TypeFox · Sep 25, 2024 · 51476b8 · 51476b8
1 parent 1ba4a1d
commit 51476b8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/wrapper/src/vscode/services.ts b/packages/wrapper/src/vscode/services.ts
@@ -51,12 +51,14 @@ export const configureServices = async (config: VscodeServicesConfig): Promise<I
 
     // set the log-level via the development settings
     const devLogLevel = serviceConfig.workspaceConfig.developmentOptions?.logLevel;
-    if (serviceConfig.workspaceConfig.developmentOptions?.logLevel === undefined) {
+    if (devLogLevel === undefined) {
 
         // this needs to be done so complicated, because developmentOptions is read-only
-        const devOptions = (serviceConfig.workspaceConfig.developmentOptions as unknown as Record<string, unknown> | undefined) ?? {};
+        const devOptions: Record<string, unknown> = {
+            ...serviceConfig.workspaceConfig.developmentOptions
+        };
         devOptions.logLevel = config.logLevel;
-        (serviceConfig.workspaceConfig.developmentOptions as Record<string, unknown>) = Object.assign(serviceConfig.workspaceConfig.developmentOptions ?? {}, devOptions);
+        (serviceConfig.workspaceConfig.developmentOptions as Record<string, unknown>) = Object.assign({}, devOptions);
     } else if (devLogLevel !== config.logLevel) {
 
         throw new Error(`You have configured mismatching logLevels: ${config.logLevel} (wrapperConfig) ${devLogLevel} (workspaceConfig.developmentOptions)`);