Handle double quoted patterns #247
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escaped backslashes `\\` within double quoted pattern arguments need to be unescaped before using xerces RegularExpression() This addresses TypeFox#239 Signed-off-by: Siddharth Sharma <[email protected]>
esmasth
commented
Sep 7, 2024
| @@ -287,6 +287,7 @@ class YangValidator extends AbstractYangValidator { | |||
| @Check | |||
| def checkPattern(Pattern it) { | |||
| // https://tools.ietf.org/html/rfc7950#section-9.4.5 | |||
| // If 'it' is double quoted replace all '\\' with '\' | |||
There was a problem hiding this comment.
@dhuebner could you please help how to achieve unescaping backslashes in case the pattern is double quoted
esmasth
force-pushed
the
esmasth/issue239
branch
from
6121909
to
46bb478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #239
https://xerces.apache.org/xerces2-j/javadocs/xerces2/org/apache/xerces/impl/xpath/regex/RegularExpression.html used by yang-lsp expects W3C pattern which is single quoted, whereas YANG double quoted syntax includes escaped backslashes
\\which need to be unescaped before passing to W3C pattern regex handler.