Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qa/#172 wish #177

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Qa/#172 wish #177

merged 2 commits into from
Dec 20, 2023

Conversation

sub101
Copy link
Member

@sub101 sub101 commented Dec 20, 2023

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

#172

๐Ÿ“ท screenshot

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-12-20 แ„‹แ…ฉแ„’แ…ฎ 12 15 42
2023-12-20.12.13.46.mov

๐Ÿ“ Work Desciption

  • ์†Œ์›๊ถŒ ๋งŒ๋“ค๊ธฐ ์„ ํƒ ์•„์ดํ…œ VISIBLE ์ฒ˜๋ฆฌ
  • ํ•œํŒ์Šน๋ถ€ ๊ฒฐ๊ณผ๋Œ€๊ธฐ & ๊ฒฐ๊ณผ๋ทฐ ํ…์ŠคํŠธ ์ปฌ๋Ÿฌ ์ˆ˜์ •

@sub101 sub101 added feat ๊ตฌํ˜„ ๋ฐ ๊ฐœ์„  ์ˆ˜๋นˆ ๐Ÿฆ„ ์œ ๋‹ˆ์˜ ์™ธ๋ชจ ๋‹ด๋‹น labels Dec 20, 2023
@sub101 sub101 self-assigned this Dec 20, 2023
Copy link
Contributor

@taeheeL taeheeL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตณ๊ตณ

@@ -54,23 +54,20 @@ class WishActivity : BindingActivity<ActivityWishBinding>(R.layout.activity_wish
wishViewModel.wishCouponList.observe(this) {
var wishList = mutableListOf<WishMultiData>()

if (it.isEmpty() && wishViewModel.isMineState.value!!) {
if (wishViewModel.isMineState.value!!) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‚˜์ค‘์— ๋„ ์ฒ˜๋ฆฌ ๊ผญ ํ•ด์ฃผ์„ธ์š”~

@taeheeL taeheeL merged commit c84ead0 into develop Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat ๊ตฌํ˜„ ๋ฐ ๊ฐœ์„  ์ˆ˜๋นˆ ๐Ÿฆ„ ์œ ๋‹ˆ์˜ ์™ธ๋ชจ ๋‹ด๋‹น
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants