Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version to 3.8 #3002

Closed

Conversation

itsarune
Copy link
Contributor

Please fill out the following before requesting review on this PR

Description

Update python version 3.8

Testing Done

Tested locally

Resolved Issues

resolves #3000

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@itsarune itsarune requested review from a team, aviwad and TylerKerswell and removed request for a team September 30, 2023 18:50
Copy link
Contributor

@TylerKerswell TylerKerswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsarune
Copy link
Contributor Author

itsarune commented Oct 1, 2023

for demo purposes

@itsarune itsarune closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sandbox Mode for Testing
2 participants