Final_speed and Target_spins_per_s #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuperzane
requested review from
a team,
williamckha and
sauravbanna
and removed request for
a team
williamckha
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Nice work! Looks like simulated_hrvo_test.py is failing -- if you can't figure out how to fix it, it's probably ok to disable that test for now since we don't use HRVO any more. We might be able to repurpose the test cases for a general motion planning test later
williamckha
reviewed
Oct 2, 2024
Co-authored-by: William Ha <[email protected]>
williamckha
reviewed
Oct 2, 2024
Co-authored-by: William Ha <[email protected]>
Lmh-java
pushed a commit
to Lmh-java/Software
that referenced
this pull request
Oct 25, 2024
* Final_speed and Target_spins_per_s * [pre-commit.ci lite] apply automatic fixes * Field chancge * Update src/proto/tactic.proto Co-authored-by: William Ha <[email protected]> * Update tactic.proto Co-authored-by: William Ha <[email protected]> * simulated hrvo fix --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: William Ha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full deletion of anything having to do with target_spin_rev_per_s and final_speed as being control params especially being updated
Testing involved building all files and watching thunderscope gameplay to ensure nothing seemed off
Resolved Issues
resolves #3145
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issueJust if you could recheck it builds would be lovely thanks!