Fixed FPS Widget #3336
Merged
Fixed FPS Widget #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Anyone
requested review from
itsarune,
williamckha and
sauravbanna
as code owners
Mr-Anyone
requested review from
a team,
nimazareian and
mkhlb
and removed request for
a team
williamckha
approved these changes
Oct 3, 2024
williamckha
requested changes
Oct 3, 2024
Comment on lines
493
to
494
| frame_swap_counter=frame_swap_frametime_counter, | ||
| refresh_counter=refresh_func_frametime_counter, |
There was a problem hiding this comment.
You should instantiate the FrametimeCounters right here instead of using the same variables for both the blue_replay_log and yellow_replay_log branches, since I think you might be able to run thunderscope with both a blue and yellow replay at the same time
There was a problem hiding this comment.
Wait, this is a thing. Ok will do
Mr-Anyone
commented
Oct 3, 2024
| @@ -487,11 +488,15 @@ def configure_replay_view( | |||
| replay_log=blue_replay_log, | |||
| visualization_buffer_size=visualization_buffer_size, | |||
| extra_widgets=[], | |||
| frame_swap_counter=FrameTimeCounter(), | |||
| refresh_counter=blue_refresh_func_counter, | |||
There was a problem hiding this comment.
I need to give some context:
This is not an anonymous object object because the same counter need to be used in both the confiure_replay_view and the TScopeTab widget. If we initialize two different object, then we run the trouble of displaying the wrong data.
williamckha
approved these changes
Oct 5, 2024
Lmh-java
approved these changes
Oct 5, 2024
…into fix_fps_widget
Lmh-java
pushed a commit
to Lmh-java/Software
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FPS Widget in Replay
Description
When viewing replay, there is an uncaught exception due to
FrametimeCounternot being initialized. This PR fixes that I think.Testing Done
Ran a replay file.
Resolved Issues
None
Length Justification and Key Files to Review
N/A
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue