Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report alternate build status #3380

Conversation

itsarune
Copy link
Contributor

Please fill out the following before requesting review on this PR

Description

When #3316 went in, I didn't realize the multi-platform builds couldn't be set as a required status check. This will force it to be reported as a status check so that it can be set as a required passing check.

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@itsarune itsarune requested review from a team, Lmh-java and wmostrenko and removed request for a team October 21, 2024 00:20
@williamckha
Copy link
Contributor

Is this necessary? I just added the alternate builds as required status checks for master:

image

@williamckha
Copy link
Contributor

Also, is there any reason why we still have separate "Software Tests" and "Robot Software Tests" jobs that build on ubuntu 20.04? Can't we just add ubuntu 20.04 to the multiplatform-build job?

@itsarune
Copy link
Contributor Author

Oh I didn't see those options earlier for some reason, thanks for checking

@itsarune
Copy link
Contributor Author

The alternate builds only check for compilation but the software tests run all of the c++ and python tests.

When I first joined tbots, our CI pipelines would take ~3 hours so the decision to not run bazel test on 22.04 was just to save time.

Nowadays, our pipelines are way faster, so we could afford to run tests on all three OSes. I don't have any preference either way, so what do you think?

@itsarune itsarune closed this Oct 21, 2024
@williamckha
Copy link
Contributor

The alternate builds only check for compilation but the software tests run all of the c++ and python tests.

When I first joined tbots, our CI pipelines would take ~3 hours so the decision to not run bazel test on 22.04 was just to save time.

Nowadays, our pipelines are way faster, so we could afford to run tests on all three OSes. I don't have any preference either way, so what do you think?

Thinking about it more, I'd rather keep what we have currently so that we can keep the jobs smaller and parallelize them. It looks like building + testing both Software and Robot Software in the same job would take 45-60 mins, compared to our CI now which takes ~30 mins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants