Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible Upgraded #3384

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

Andrewyx
Copy link
Contributor

Please fill out the following before requesting review on this PR

Upgrades Ansible to support Python 3.12

Description

Testing Done

Flashes successfully onto robot.

Resolved Issues

Follows up with #3316, requires #3383

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Mr-Anyone
Copy link
Contributor

I think this things work from what I can tell.

@Andrewyx Andrewyx merged commit b62a9e8 into UBC-Thunderbots:master Oct 23, 2024
7 checks passed
Lmh-java pushed a commit to Lmh-java/Software that referenced this pull request Oct 25, 2024
* fixed deploy

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants