Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add as_curve_params test #215

Merged
merged 10 commits into from
Jul 30, 2024
Merged

add as_curve_params test #215

merged 10 commits into from
Jul 30, 2024

Conversation

chrisorwa
Copy link
Collaborator

Add test for as_curve_params

@chrisorwa chrisorwa linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
R/as_curve_params.R 83.33% <100.00%> (+10.00%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests! Please see comments below.

tests/testthat/test-as_curve_params.R Outdated Show resolved Hide resolved
tests/testthat/test-as_curve_params.R Outdated Show resolved Hide resolved
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job using the error class! Please reduce the snapshot size (see comment).

tests/testthat/_snaps/as_curve_params.md Outdated Show resolved Hide resolved
R/as_curve_params.R Outdated Show resolved Hide resolved
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing the file size! Please see comment below; we're still not capturing the console-printed output in the test starting on line 13.

tests/testthat/test-as_curve_params.R Show resolved Hide resolved
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some accidental keystrokes snuck in; see inline comment. Otherwise, looks good!

class = "not curve_params"
)
})
de
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a few accidental keystrokes snuck in here on line 11: de

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the accidental keystroke. I have made the correction.

@lokune lokune requested a review from d-morrison July 30, 2024 12:59
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for adding these tests.

@d-morrison d-morrison merged commit b2567be into main Jul 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create test for as_curve_params
2 participants