Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting Demo #1910

Closed
wants to merge 5 commits into from
Closed

Reporting Demo #1910

wants to merge 5 commits into from

Conversation

TrevorAntony
Copy link

@TrevorAntony TrevorAntony commented Jul 23, 2024

I have updated the PR
Screenshot 2024-07-24 at 16 10 51
Screenshot 2024-07-24 at 16 11 02

…estoring the 'COVID' tab on the dasshboard affects routing
Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TrevorAntony , please undo the changes in the yarn.lock and package.json file

label="Select a report to display"
items={[
{ id: 'ecabd559-14f6-4c65-87af-1254dfdf1304', text: 'Covid-19 Report' },
{ id: '3ffa5a53-fc65-4a1e-a434-46dbcf1c2de2', text: 'HTS Report' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add these uuids in the config

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the requested changes. kindly check new commit

@hadijahkyampeire
Copy link
Contributor

Thanks @TrevorAntony, please look at the build failures

Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some visual feedback,

  1. Could you leave a padding left before the reports dropdown and the fetch button.
  2. Green for table headers looks too much 🤔

@hadijahkyampeire
Copy link
Contributor

@TrevorAntony following our sync earlier here is some feedback we talked about, let me know if you need any assistance

  • Cover at least 90% of the width for the filtering section
  • Try to display the button on the same line as the filters
  • Remove the green background in the table header
  • Use SWR to fetch the report
  • Translate the column headers

@hadijahkyampeire
Copy link
Contributor

@TrevorAntony let's close this

@TrevorAntony
Copy link
Author

TrevorAntony commented Jul 26, 2024 via email

@TrevorAntony TrevorAntony deleted the Feat-DisplayReports branch July 26, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants