Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4052: Wrap SideNavMenu title in t function #1928

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

NethmiRodrigo
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

When there is a grouped link the NavBarMenu title does not get translated. This PR fixes that by wrapping the title in the t function.

Screenshots

After fix:
Screenshot 2024-10-03 at 11 02 49 AM

Before fix:
Screenshot 2024-10-03 at 11 04 29 AM

Related Issue

https://ohri.atlassian.net/browse/O3-4052

Other

I had to upgrade the openmrs framework version which is why I included the yarn.lock.

@NethmiRodrigo NethmiRodrigo marked this pull request as draft October 3, 2024 05:45
@NethmiRodrigo NethmiRodrigo marked this pull request as ready for review October 3, 2024 05:45
@NethmiRodrigo
Copy link
Contributor Author

@ibacher @CynthiaKamau requesting for a review, can't seem to be able to do it on the UI

Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NethmiRodrigo , please fix the build errors

@NethmiRodrigo
Copy link
Contributor Author

@CynthiaKamau I updated the yarn.lock again, could you please approve the workflows, thanks.

@gracepotma
Copy link

Maybe an obvious question but: Why do we need to work in here instead of in the OpenMRS repo: https://github.com/openmrs/openmrs-content-hiv

@NethmiRodrigo
Copy link
Contributor Author

@gracepotma this PR was to make the string that shows up in the navbar translatable, so its not a part of the content but rather a fix to the implementation.

@NethmiRodrigo
Copy link
Contributor Author

@CynthiaKamau I updated the encounter-tile.test to fix the importDynamic initialization error. Could you please re-run the worflows?

@NethmiRodrigo
Copy link
Contributor Author

@CynthiaKamau es2022 was missing in the tsconfig in esm-commons-lib, I added it and the build passed locally, could you please approve the workflows again?

@NethmiRodrigo
Copy link
Contributor Author

@CynthiaKamau the e2e test was failing because the defaultLocale was set to French in the instance, I've changed it back to English and it passes locally, could you re-run the workflow?

Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NethmiRodrigo
Copy link
Contributor Author

Thanks for reviewing @CynthiaKamau, could you please merge this in, I don't have the permission to do so.

@CynthiaKamau CynthiaKamau merged commit 3cf5e33 into UCSF-IGHS:dev Oct 14, 2024
5 checks passed
@CynthiaKamau
Copy link
Contributor

@CynthiaKamau I updated the encounter-tile.test to fix the importDynamic initialization error. Could you please re-run the worflows?

Done

@NethmiRodrigo NethmiRodrigo deleted the fix/O3-4052 branch October 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants