Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/reference sitemap when crawling frontend /cdd 2260 #1868

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

A-Ashiq
Copy link
Contributor

@A-Ashiq A-Ashiq commented Oct 18, 2024

Description

This PR includes the following:

  • Traverses the frontend by making use of the sitemap instead of trying to build the URLs ourselves. Which we had to do originally before the sitemap was in place

Fixes #CDD-2260


Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@A-Ashiq A-Ashiq merged commit a2b4c46 into main Oct 18, 2024
13 of 14 checks passed
@A-Ashiq A-Ashiq deleted the task/reference-sitemap-when-crawling-frontend--/CDD-2260 branch October 18, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants