Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#CDD-891: Migrate from Cypress to Playwright #157

Merged
merged 21 commits into from
Aug 3, 2023
Merged

#CDD-891: Migrate from Cypress to Playwright #157

merged 21 commits into from
Aug 3, 2023

Conversation

8lane
Copy link
Contributor

@8lane 8lane commented Aug 1, 2023

Description

  • Add Playwright & converted all Cypress tests
  • Added additional coverage for all homepage and topic pages
  • Remove Cypress

Fixes #CDD-891

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Unit tests coverage

Lines Statements Branches Functions
Coverage: 96%
95.54% (687/719) 77.77% (98/126) 96.29% (78/81)
Tests Skipped Failures Errors Time
118 4 💤 0 ❌ 0 🔥 23.995s ⏱️

@8lane 8lane marked this pull request as ready for review August 3, 2023 07:41
@8lane 8lane changed the title WIP: Setup playwright #CDD-891: Migrate from Cypress to Playwright Aug 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
9.8% 9.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@8lane 8lane merged commit 772f7be into main Aug 3, 2023
9 of 10 checks passed
@8lane 8lane deleted the spike/playwright branch August 3, 2023 08:35
8lane added a commit that referenced this pull request Jan 18, 2024
#CDD-891: Migrate from Cypress to Playwright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants