[DO NOT MERGE] chore: FE caching (Redis) #525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests coverage
|
A-Ashiq
reviewed
Oct 8, 2024
|
|
||
| const globalBanner = await getGlobalBanner() | ||
| const getBanner = cache(getGlobalBanner) | ||
| const getFlag = cache(getFeatureFlag) |
There was a problem hiding this comment.
What does the workflow for this look like when we wanna switch a flag in the FE, is it something like:
- Switch flag
- Flush caches
- Restart containers
But what if the flag value is cached in the frontend cache between steps 1 and 2? Does that mean when we flush caches, the CDN crawler will hit the frontend showing the stale value?
There was a problem hiding this comment.
Arguably the crawler always fills the redis cache first so there would be enough time between the 2. So maybe this is okay
A-Ashiq
previously approved these changes
Oct 8, 2024
|
8lane
changed the title
8lane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cross-fetch14.2.14cacheand parallel requests in root layout, homepage and dynamic page rendererssr: falseflag for dynamic import