Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser nav & remove the need to double-ENTER on the searchbar #298

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Fix browser nav & remove the need to double-ENTER on the searchbar #298

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3832725
make back nav more intuitive (every time you click search it adds to …
AbhiramTadepalli Oct 31, 2024
e9e6e10
Dynamically change page title based on searchTerms. Helps make back n…
AbhiramTadepalli Nov 1, 2024
57f4566
lint check
AbhiramTadepalli Nov 1, 2024
1ce794d
Trigger new search when clicking ENTER to select add an autocomplete …
AbhiramTadepalli Nov 2, 2024
c93e6a9
Fix formatting of the header (trailing comma, add 'Results - ' at the…
AbhiramTadepalli Nov 2, 2024
673bbf4
Remove state
TyHil Nov 8, 2024
11e2a2f
Bring the meta property for link preview into dashboard/index.tsx so …
AbhiramTadepalli Nov 8, 2024
9dc3e06
(revert later) add a test to diagnose link preview bug
AbhiramTadepalli Nov 8, 2024
17f3293
Revert "Remove state"
AbhiramTadepalli Nov 8, 2024
143f080
Reapply "Remove state"
AbhiramTadepalli Nov 8, 2024
a782977
Revert "(revert later) add a test to diagnose link preview bug"
AbhiramTadepalli Nov 8, 2024
96afc30
try to directly make the meta tag from the url
AbhiramTadepalli Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/pages/dashboard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,10 @@ export const Dashboard: NextPage = () => {
professorSearchTerms.map((term) => {
str += searchQueryLabel(term) + ', ';
});
str =
str.lastIndexOf(', ') === str.length - 2
? str.substring(0, str.lastIndexOf(', ')) + ' - '
: str;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this line. Is there a more efficient way?
It also has the fun property that if str is somehow length 1, the if condition is true -> it tries the substring

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't str always empty until anything is added to it?
And running str.slice(0, -2) on any empty string causes no error and just returns an empty string.
So why not just str = str.slice(0, -2);

When is str ever length 1 tho? It's either nothing or it has a search term plus ", " added to it. Either way, I think the above solution works

setPageTitle(str);
}
TyHil marked this conversation as resolved.
Show resolved Hide resolved

Expand Down Expand Up @@ -780,7 +784,7 @@ export const Dashboard: NextPage = () => {
return (
<>
<Head>
<title>{pageTitle + ' - UTD TRENDS'}</title>
<title>{'Results - ' + pageTitle + 'UTD TRENDS'}</title>
<link
rel="canonical"
href="https://trends.utdnebula.com/dashboard"
Expand Down
Loading