fix_add_special_feature_tests #778 #783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftnext
reviewed
Nov 3, 2024
ftnext
requested changes
Nov 5, 2024
tests/test_special_features.py
Outdated
| # Load the audio file for recognition | ||
| # Attempt to record audio from the MP3 file | ||
| with sr.AudioFile(self.AUDIO_FILE_EN_MP3) as source:r.record(source) | ||
|
|
There was a problem hiding this comment.
This file contains tests for the Recognizer's recognize_sphinx() method,
and I think the added test is for AudioFile.
So I think it should be added to test_audio.py instead of test_special_features.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_incompatible_audio_file_error test failed and raised the ValueError as mp3 format.
The test_sphinx_keywords fixed the tests before as they failed
Issue #778