Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hooks & conventions #27

Merged
merged 4 commits into from
Sep 23, 2023
Merged

pre-commit hooks & conventions #27

merged 4 commits into from
Sep 23, 2023

Conversation

Baklap4
Copy link
Collaborator

@Baklap4 Baklap4 commented Sep 22, 2023

What does this PR do?

  • Adds pre-commit + documentation how to install
  • Changed the source to fix the found issues

To test this please install pre-commit by checking what's in the CONTRIBUTOR.md

Closes Issue(s)

Closes #26

Motivation

Standardization and following conventions

More

  • Added/updated documentation

Additional Notes

@marwin89 please double check if the website still works i've fixed a couple of tags which have been duplicated or didnt have a closing tag at all...
I didn't find a html pre-commit checker.. but that'd be better... so i've manually checked it here: https://validator.w3.org/nu/#textarea

@marwin89
Copy link
Collaborator

Thanks @Baklap4 , the website looks good. No Errors in the validator. Line endings are now in LF. Much better. 👍 💯

Copy link
Collaborator

@marwin89 marwin89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 This makes things much easier 🎸 I just approved it.

@Baklap4 Baklap4 merged commit 26645fb into main Sep 23, 2023
1 check passed
@Baklap4 Baklap4 deleted the fix/eol branch September 23, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Repository] Introduce pre-commit (git hooks automation)
2 participants