Fix UTMT crash when searching for a lot of unreferenced assets #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, in Undertale, if you tried to find unreferenced assets in all groups UTMT would crash. This fixes that.
|
Yes, I encountered the bug on the latest commit (caf0412). Later I'll comment attaching a video recreating the bug. |
|
Before: After: There's a problem with my code that I noticed just now: It doesn't find unused strings. |
|
I checked with Undertale version 1.08 and that's why I couldn't reproduce the bug. |
|
I created a more permanent fix for this in PR #1947. Thank you for finding this bug. |
|
Thank you for fixing it! |
|
Closing, as this is superseded by #1947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, in Undertale, if you tried to find unreferenced assets in all groups UTMT would crash. This fixes that by using just a try catch.
Description
Old error:
Caveats
Notes