Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move torsoriality of the identity type to foundation-core.torsorial-type-families #1065

Merged
merged 14 commits into from
Mar 14, 2024

Conversation

EgbertRijke
Copy link
Collaborator

This PR moves the torsoriality of the identity types to foundation-core.torsorial-type-families. Previously it was in contractible-types. I also slightly updated the prose, and fixed imports wherever they were broken because of this move.

@EgbertRijke EgbertRijke changed the title Move torsoriality of the identity type to foundation-core.torsorial-type-families chore: Move torsoriality of the identity type to foundation-core.torsorial-type-families Mar 12, 2024
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@fredrik-bakke
Copy link
Collaborator

Would it be nice to also mention in the ## Idea section that the identity type family is the motivating example of the definition?

@EgbertRijke
Copy link
Collaborator Author

Question: When running make website I get the following error. What should I do to make it go away?

Traceback (most recent call last):
  File "/Users/egbertrijke/Repositories/agda-unimath/./scripts/preprocessor_citations.py", line 8, in <module>
    import pybtex
ModuleNotFoundError: No module named 'pybtex'

@fredrik-bakke
Copy link
Collaborator

Question: When running make website I get the following error. What should I do to make it go away?

Traceback (most recent call last):
  File "/Users/egbertrijke/Repositories/agda-unimath/./scripts/preprocessor_citations.py", line 8, in <module>
    import pybtex
ModuleNotFoundError: No module named 'pybtex'

You have to install the latest requirements. What you're missing is the pybtex module

@VojtechStep
Copy link
Collaborator

I'd expect this property to be recorded in foundation.identity-types - are there circular dependency issues with that?

@fredrik-bakke
Copy link
Collaborator

Question: When running make website I get the following error. What should I do to make it go away?

Traceback (most recent call last):
  File "/Users/egbertrijke/Repositories/agda-unimath/./scripts/preprocessor_citations.py", line 8, in <module>
    import pybtex
ModuleNotFoundError: No module named 'pybtex'

You have to install the latest requirements. What you're missing is the pybtex module

The command would be pip3 install -r scripts/requirements.txt unless you've recently updated python with brew. If so, the command is pip3 install -r scripts/requirements.txt --break-system-packages

@EgbertRijke
Copy link
Collaborator Author

I'd expect this property to be recorded in foundation.identity-types - are there circular dependency issues with that?

You're right, and yes that leads to cyclic module dependencies that I don't want to solve now.

@EgbertRijke
Copy link
Collaborator Author

Would it be nice to also mention in the ## Idea section that the identity type family is the motivating example of the definition?

On it.

@EgbertRijke EgbertRijke changed the title chore: Move torsoriality of the identity type to foundation-core.torsorial-type-families Move torsoriality of the identity type to foundation-core.torsorial-type-families Mar 12, 2024
@EgbertRijke
Copy link
Collaborator Author

I removed "chore" from the title of this PR because I wrote a somewhat substantial amount of text and that should definitely count as content creation.

@VojtechStep VojtechStep merged commit 2c80040 into UniMath:master Mar 14, 2024
4 checks passed
fredrik-bakke pushed a commit to fredrik-bakke/agda-unimath that referenced this pull request Mar 14, 2024
…type-families` (UniMath#1065)

This PR moves the torsoriality of the identity types to
`foundation-core.torsorial-type-families`. Previously it was in
`contractible-types`. I also slightly updated the prose, and fixed
imports wherever they were broken because of this move.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants