-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hofmann-Streicher universes for graphs and globular types #1196
Conversation
…endendent globular types with morphisms into the universal globular type
I have now proven the duality theorem for directed graphs (analogous to type duality), which is the toy-result of what I'm really after for globular types. |
Unfortunately, it is a choice between two evils, unless we want to start playing with making changes to the auto-formatter. Luckily your issue can be avoided by being mindful of how one comments code. Your best course of action here is to look through the commit history for a point in time where the code wasn't jumbled. Alternatively, you could try something like text replacing |
Hiya! It looks like this PR is perhaps growing a bit outside the scope of the original goal. While I don't doubt the changes are relevant to one another, do you think it perhaps would be possible to split it up into some more manageable chunks for the eventual review? |
This PR should be merged before #1196. I have only moved files and adjusted imports and markdown links accordingly, in an attempt to preserve the credits to the content creators.
I believe I've addressed all the review comments, except one where I asked if it is ok to leave it unaddressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment without finishing my review 😩
src/structured-types/large-lax-reflexive-globular-maps.lagda.md
Outdated
Show resolved
Hide resolved
src/globular-types/binary-dependent-reflexive-globular-types.lagda.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crazy stuff! But next time, maybe try and keep the PR a little smaller 😬
src/globular-types/composition-structure-globular-types.lagda.md
Outdated
Show resolved
Hide resolved
You're right. Sorry! Thanks so much for reviewing this beast! |
Sorry to rush you, but could we try to get this PR merged? The outstanding comments are very minor, and I'd like to continue work on wild higher categories. |
I wouldn't mind making the final fixes without credit so we could get this PR merged, for instance. |
Don't sweat it, I'll be working on a branch off of your current version of things in the meantime. I am trying not to have too much overlap in case you make bigger changes, but I'm making additions to composition structures that I can use to define and work with noncoherent wild ω-semiprecatgories. I want to start with semiprecategories because there are some interesting things to say about the nonunital case. From there I propose we define noncoherent wild ω-precategories as noncoherent wild ω-semiprecatgories that are reflexive and whose composition structure is unital. |
This pull request is part of the formalization of higher category theory project with Ivan. Here we construct Hofmann-Streicher universes for:
Additionally, we add some computations for dependent Pi-types in those toposes, and some infrastructure is streamlined.