Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some fixes to links #1217

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore: some fixes to links #1217

merged 2 commits into from
Oct 29, 2024

Conversation

fredrik-bakke
Copy link
Collaborator

Noticed a couple of issues after the recent changes.

@EgbertRijke
Copy link
Collaborator

Thanks for catching these! I noticed a couple of others, but didn't make a PR yet.

  1. Jonathan isn't linked in the readme. I wonder if I didn't save my search-replace on his name and left it out in other places too.
  2. Freek's name is sometimes split over multiple sentences, and I didn't link those occurrences of his name. Perhaps some other names aren't linked for the same reason.

@fredrik-bakke
Copy link
Collaborator Author

Thanks for catching these! I noticed a couple of others, but didn't make a PR yet.

  1. Jonathan isn't linked in the readme. I wonder if I didn't save my search-replace on his name and left it out in other places too.
  2. Freek's name is sometimes split over multiple sentences, and I didn't link those occurrences of his name. Perhaps some other names aren't linked for the same reason.

Do you want me to correct these as well?

@EgbertRijke
Copy link
Collaborator

Thanks for catching these! I noticed a couple of others, but didn't make a PR yet.

  1. Jonathan isn't linked in the readme. I wonder if I didn't save my search-replace on his name and left it out in other places too.
  2. Freek's name is sometimes split over multiple sentences, and I didn't link those occurrences of his name. Perhaps some other names aren't linked for the same reason.

Do you want me to correct these as well?

If you're willing to do that, that would be great! Thanks so much!

@fredrik-bakke fredrik-bakke changed the title chore: some minor fixes to links chore: some fixes to links Oct 29, 2024
@EgbertRijke
Copy link
Collaborator

Thanks for the fixes! Feel free to merge when you're ready

@fredrik-bakke fredrik-bakke enabled auto-merge (squash) October 29, 2024 16:38
@fredrik-bakke fredrik-bakke merged commit 7cfae63 into UniMath:master Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants