Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch optimism testnet from kovan to goerli #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

annieke
Copy link

@annieke annieke commented Sep 26, 2022

Switching Optimism testnet from Kovan to Goerli: https://dev.optimism.io/kovan-to-goerli/

interface PR: Uniswap/interface#4719

@vercel
Copy link

vercel bot commented Sep 26, 2022

@annieke is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
widgets ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 5:07PM (UTC)

@vercel vercel bot temporarily deployed to Preview September 26, 2022 15:28 Inactive
Copy link
Contributor

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few questions

logoUrl: optimismLogoUrl,
statusPage: 'https://optimism.io/status',
helpCenterUrl: 'https://help.uniswap.org/en/collections/3137778-uniswap-on-optimistic-ethereum-oξ',
nativeCurrency: { name: 'Optimistic Kovan Ether', symbol: 'kovOpETH', decimals: 18 },
nativeCurrency: { name: 'Optimism Görli Ether', symbol: 'görOpETH', decimals: 18 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this symbol come from? Why does this use ö instead of oe, like the rest of the labels?

Copy link
Author

@annieke annieke Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goerli in this same file uses the symbol, copypastaed here for consistency

nativeCurrency: { name: 'Görli Ether', symbol: 'görETH', decimals: 18 },

'0x3b8e53b3ab8e01fb57d0c9e893bc4d655aa67d84',
export const USDC_OPTIMISM_GOERLI = new Token(
SupportedChainId.OPTIMISM_GOERLI,
'0x7E07E15D2a87A24492740D16f5bdF58c16db0c4E',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you pull this address from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just unsure why the tests are no longer passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants