Fix Issue #1082 added lang attribute for language specific pronunciation

[thattonBL]

• lang attribute added to parent div of all UV elements which should cascade down

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
universalviewer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2024 11:58am

[demiankatz]

Thanks, @thattonBL, this seems to be working as expected (in terms of adding the lang attribute -- the interaction of this attribute with various screen readers is beyond my ability to test). Before we merge this, though, I wonder if we should add better lang attribute support to iiif-metadata-component, since the metadata in that panel may be a different language from the interface, and those elements do not currently appear to be labeled. I think we have enough data in the panel to label each value, so we should probably start doing that. I don't have time to investigate it just yet, but it may not be too difficult when time permits!

[LanieOkorodudu]

@thattonBL and @demiankatz, I've tested this fix on the Vercel app, verifying the fix in Dev Tools and comparing it with the dev branch. All changes function as expected. I validated the lang attribute across all available languages, confirming it is correctly applied and behaving as intended.

[demiankatz]

So I think the question now is whether we merge this as-is (incremental progress) or wait until some more nuance has been added. Do you have an opinion, @scoutb-cogapp?