-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to supported go versions #157
Open
chriswk
wants to merge
10
commits into
v4
Choose a base branch
from
bumpToSupportedGoVersions
base: v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c633190
chore: update to supported go versions
chriswk 748b1de
Make sure yaml doesn't treat 1.20 as 1.2
chriswk 6306262
Bumped to latest version of actions
chriswk 0075479
go mod tidy
chriswk 425f359
add grace period for race tests
chriswk 6a71d49
reverted timeout
chriswk 8680485
Merge branch 'v4' into bumpToSupportedGoVersions
ea2b7b5
Merge remote-tracking branch 'origin/v4' into bumpToSupportedGoVersions
gastonfournier ef3e22d
Add same build matrix versions as in build
gastonfournier 5912690
chore: test with same version in go.mod and newer versions in matrix
gastonfournier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,11 @@ | ||
| module github.com/Unleash/unleash-client-go/v4 | ||
|
|
||
| go 1.13 | ||
|
|
||
| require ( | ||
| github.com/Masterminds/semver/v3 v3.1.1 | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/Masterminds/semver/v3 v3.2.1 | ||
| github.com/h2non/gock v1.2.0 | ||
| github.com/nbio/st v0.0.0-20140626010706-e9e8d9816f32 | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/stretchr/objx v0.1.1 // indirect | ||
| github.com/stretchr/testify v1.2.2 | ||
| github.com/stretchr/testify v1.9.0 | ||
| github.com/twmb/murmur3 v1.1.8 | ||
| ) | ||
|
|
||
| go 1.13 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have explosion of versions here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that go 1.17 updated the format for go.mod/go.sum, and since we now explicitly state go 1.19 in our go.mod, the new format takes effect.