fix: variant stickiness from strategy (#570)

Unleash · Jan 23, 2024 · da6120b · da6120b
1 parent 8fa90e2
commit da6120b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -56,7 +56,7 @@
     "@types/sinon": "^17.0.0",
     "@typescript-eslint/eslint-plugin": "^6.0.0",
     "@typescript-eslint/parser": "^6.0.0",
-    "@unleash/client-specification": "^5.1.0",
+    "@unleash/client-specification": "^5.1.4",
     "ava": "^5.3.0",
     "coveralls": "^3.1.1",
     "cross-env": "^7.0.3",

diff --git a/src/strategy/strategy.ts b/src/strategy/strategy.ts
@@ -227,8 +227,9 @@ export class Strategy {
       this.isEnabledWithConstraints(parameters, context, constraints);
 
     if (enabled && Array.isArray(variants) && variants.length > 0) {
+      const stickiness = variants[0].stickiness || parameters.stickiness;
       const variantDefinition =
-        selectVariantDefinition(parameters.groupId, variants, context);
+        selectVariantDefinition(parameters.groupId, stickiness, variants, context);
       return variantDefinition ? {
         enabled: true,
         variant: {

diff --git a/src/variant.ts b/src/variant.ts
@@ -98,6 +98,7 @@ function findOverride(
 
 export function selectVariantDefinition(
   groupId: string,
+  stickiness: string | undefined,
   variants: VariantDefinition[],
   context: Context,
 ): VariantDefinition | null {
@@ -110,8 +111,6 @@ export function selectVariantDefinition(
     return variantOverride;
   }
 
-  const { stickiness } = variants[0];
-
   const target = normalizedVariantValue(getSeed(context, stickiness), groupId, totalWeight);
 
   let counter = 0;
@@ -132,5 +131,6 @@ export function selectVariant(
   feature: FeatureInterface,
   context: Context,
 ): VariantDefinition | null {
-  return selectVariantDefinition(feature.name, feature.variants || [], context);
+  const stickiness = feature.variants?.[0]?.stickiness ?? undefined;
+  return selectVariantDefinition(feature.name, stickiness, feature.variants || [], context);
 }
diff --git a/yarn.lock b/yarn.lock
@@ -888,10 +888,10 @@
   resolved "https://registry.yarnpkg.com/@ungap/structured-clone/-/structured-clone-1.2.0.tgz#756641adb587851b5ccb3e095daf27ae581c8406"
   integrity sha512-zuVdFrMJiuCDQUMCzQaD6KL28MjnqqN8XnAqiEq9PNm/hCPTSGfrXCOfwj1ow4LFb/tNymJPwsNbVePc1xFqrQ==
 
-"@unleash/client-specification@^5.1.0":
-  version "5.1.3"
-  resolved "https://registry.yarnpkg.com/@unleash/client-specification/-/client-specification-5.1.3.tgz#660090a0b96aef3eeb4086f40c4aa9fdf4cebdec"
-  integrity sha512-52QcYjKZ/OqvOPgqtnr5HLke1Aqdgs/bYZa/byYD+LQ40SW1EJB1vUcSsMdEYWMuW4j533g24mMs1DZhkG+dvQ==
+"@unleash/client-specification@^5.1.4":
+  version "5.1.4"
+  resolved "https://registry.yarnpkg.com/@unleash/client-specification/-/client-specification-5.1.4.tgz#5e5df5749bb6828f127020771c5f9150d7b0e4c8"
+  integrity sha512-zJMQT0olV9LKlYXbgJrnv08Tbh6G+tXh9s07Z8UvCroItmxJEO/+f6lIhtZh5b+79TdrROt8Sg85mAr+rRnhlQ==
 
 acorn-jsx@^5.3.2:
   version "5.3.2"