chore: incoming webhook events #5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
gastonfournier
approved these changes
Dec 20, 2023
| INCOMING_WEBHOOK_UPDATED, | ||
| INCOMING_WEBHOOK_DELETED, | ||
| INCOMING_WEBHOOK_TOKEN_CREATED, | ||
| INCOMING_WEBHOOK_TOKEN_UPDATED, |
There was a problem hiding this comment.
Do you see a case where the webhook can be updated? Maybe something like GH tokens where they have an expiration date and you can regenerate the secret?
There was a problem hiding this comment.
That's a good question. The way I see it:
- You can update the incoming webhook by updating its enabled state (toggling them)
- You can potentially update the token by updating its name
But no strong feelings about this. I'm also OK with not allowing updating the token names.
There was a problem hiding this comment.
Ok! I think I was not considering the token name as a property we could change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1748/create-new-incoming-webhook-events
Adds new events for write operations on incoming webhooks and their tokens.