feat: implement column created_by_user_id in feature_tag #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -24,4 +24,6 @@ export interface FeatureTagSchema { | |||
| * @deprecated | |||
| */ | |||
| value?: string; | |||
| /** The id of the user who created this tag */ | |||
| createdByUserId?: number; | |||
There was a problem hiding this comment.
If previously it didn't have a user, can we assume system here? I mean to avoid having it nullable, I feel we're not accomplishing our goal if this is nullable
| @@ -35,6 +35,12 @@ export const featureTagSchema = { | |||
| description: | |||
| 'The value of the tag. This property is deprecated and will be removed in a future version of Unleash. Superseded by the `tagValue` property.', | |||
| }, | |||
| createdByUserId: { | |||
| type: 'number', | |||
| nullable: true, | |||
There was a problem hiding this comment.
Just a note so we don't forget: maybe we need to make this not nullable, but if this is used as input it might be a breaking change for the API
There was a problem hiding this comment.
Yeah this is part of import/export. So I think it needs to be nullable
| @@ -159,4 +159,5 @@ export const featureTagSchema = joi.object().keys({ | |||
| tagValue: joi.string(), | |||
| type: nameType.optional(), | |||
| value: joi.string().optional(), | |||
| createdByUserId: joi.number().optional(), | |||
There was a problem hiding this comment.
I think this is used to validate input. And I believe all new input should have a createdById (but maybe it's a breaking change for the API)
gastonfournier
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adds the new nullable column created_by_user_id to the data used by feature-tag-store and feature-tag-service. Also updates openapi schemas.