fix: last seen cherrypick #5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Dec 21, 2023
| @@ -399,8 +399,11 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { | |||
| } | |||
|
|
|||
| if ( | |||
| acc.lastSeenAt === undefined || | |||
| new Date(r.env_last_seen_at) > new Date(acc.lastSeenAt) | |||
| acc.lastSeenAt == null || | |||
There was a problem hiding this comment.
this is required as new Date(undefined) doesn't work correctly as new Date(null)
There was a problem hiding this comment.
But would acc.lastSeenAt now be undefined and not null because of the removal on this line?
There was a problem hiding this comment.
yes, but the line I removed was always breaking the current acc state
ivarconr
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Cherry picking last seen at fixes
Important files
Discussion points