Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add more tests for the lifecycle avg calculation query #8698

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Nov 8, 2024

This PR adds more tests to check a few more cases for the lifecycle calculation query. Specifically, it tests that:

  • If we don't have any data for a stage, we return null.
  • We filter on projects
  • It correctly takes 0 days into account when calculating averages.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:31am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:31am

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter was failing because of this 🤷🏼

@thomasheartman thomasheartman merged commit 0a250a7 into main Nov 8, 2024
11 of 12 checks passed
@thomasheartman thomasheartman deleted the 1-3085/add-data-to-api-response branch November 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants