Cake5 #20
Merged
Cake5 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….php, replaced zackkitzmiller/tiny with tuupola/base62 for base62 obfluscation, added TuupolaStrategy
ADmad
reviewed
Sep 23, 2023
…Strategy.php, removed deprecation tag from TinyStrategy.php
ADmad
reviewed
Sep 24, 2023
ADmad
reviewed
Sep 25, 2023
ADmad
reviewed
Sep 26, 2023
| /** | ||
| * Class TinyStrategy | ||
| * | ||
| * @deprecated Use Muffin\Obfuscate\Model\Behavior\Strategy\Base62Strategy instead | ||
| */ | ||
| class TinyStrategy implements StrategyInterface |
There was a problem hiding this comment.
I am wondering if we should just drop this TinyStragtegy. Existing users will have to change the underlying lib anyway, so they can change the strategy name too.
There was a problem hiding this comment.
You're right, we may drop the TinyStrategy completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial upgrade to CakePHP5.0 and phpunit 10, when accepted please merge this PR with new branch
cake5. Thank you