Rust APIのunsafe_codeをallowにする (#773)

voicevox_coreの`unsafe_code`を`allow`にする
VOICEVOX · Apr 15, 2024 · 7afc276 · 7afc276
1 parent 1788d60
commit 7afc276
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/crates/voicevox_core/Cargo.toml b/crates/voicevox_core/Cargo.toml
@@ -56,5 +56,8 @@ humansize.workspace = true
 windows = { workspace = true, features = ["Win32_Foundation", "Win32_Graphics_Dxgi"] }
 
 [lints.rust]
-unsafe_code = "deny" # FIXME: あまり意味が無くなっているため潔く`allow`にする。あるいはunsafeを撲滅する
+# FIXME: `unsafe impl Send`のもあるが、以下2つのマージにより消える予定
+# * https://github.com/VOICEVOX/voicevox_core/pull/725
+# * https://github.com/VOICEVOX/voicevox_core/pull/772
+unsafe_code = "allow" # WindowsのGPU情報表示に、Win32を利用
 rust_2018_idioms = "warn"
diff --git a/crates/voicevox_core/src/engine/open_jtalk.rs b/crates/voicevox_core/src/engine/open_jtalk.rs
@@ -183,7 +183,6 @@ pub(crate) mod blocking {
     }
 
     // FIXME: open_jtalk-rs側で宣言する
-    #[allow(unsafe_code)]
     unsafe impl Send for Resources {}
 }
 

diff --git a/crates/voicevox_core/src/infer/runtimes/onnxruntime.rs b/crates/voicevox_core/src/infer/runtimes/onnxruntime.rs
@@ -249,6 +249,5 @@ mod assert_send {
     }
 
     // SAFETY: `Session` is probably "send"able.
-    #[allow(unsafe_code)]
     unsafe impl<T> Send for AssertSend<T> {}
 }
diff --git a/crates/voicevox_core/src/synthesizer.rs b/crates/voicevox_core/src/synthesizer.rs
@@ -1017,7 +1017,6 @@ pub(crate) mod blocking {
         }
 
         fn list_windows_video_cards() -> windows::core::Result<Vec<DXGI_ADAPTER_DESC>> {
-            #[allow(unsafe_code)]
             unsafe {
                 let factory = CreateDXGIFactory::<IDXGIFactory>()?;
                 (0..)