Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#538 のコメントを反映 #546

Merged
merged 5 commits into from
Jul 28, 2023
Merged

#538 のコメントを反映 #546

merged 5 commits into from
Jul 28, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

#538 のコメントを反映します。

関連 Issue

その他

（なし）

Hiroshiba
Hiroshiba approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

移動も良い感じに思いました。

@sevenc-nanashi
Copy link
Member Author

pyファイルの変更時にBlackやisort走らせるworkflow、作りたいですね

qryxip
qryxip approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit f1dd63b into VOICEVOX:main Jul 28, 2023
45 checks passed
@sevenc-nanashi sevenc-nanashi deleted the improve/fixup-dict branch July 28, 2023 22:13
@qryxip qryxip mentioned this pull request Jul 30, 2023
Merged
8 tasks
@qryxip qryxip mentioned this pull request Aug 6, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@qryxip qryxip qryxip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevenc-nanashi @Hiroshiba @qryxip