Java API：Android版の設計を色々修正 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
commented
Sep 14, 2023
Comment on lines
23
to
24
| * <p> | ||
| * この関数を呼び出した後にユーザー辞書を変更した場合は、再度この関数を呼ぶ必要がある。 |
There was a problem hiding this comment.
ビルドのためにgradlew spotlessApplyしたら色々と変わりました。
sevenc-nanashi
commented
Sep 14, 2023
There was a problem hiding this comment.
#558 (comment)
これで消えてなかったので消しました。
Hiroshiba
reviewed
Sep 14, 2023
|
コメントを反映しました。 |
Hiroshiba
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
微妙に細かいところよくわかってませんが、とりあえずlgtm！！！
@qryxip さんがコメントしてくださってます。気づいてなかったらあれなので言及してみました。
#612 (comment)
|
@qryxip 2つapprove集まったら全然マージしちゃって大丈夫です！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
割と色々と設計ミスしてたのを修正します。
aar）を作るにはbuild.gradleがもう一つ必要だったので追加しました。TARGET環境変数で切り換える感じです。関連 Issue
その他
aarは依存関係情報を含まないため、Mavenリポジトリを作って上げる（ダブルミーニング）必要があるっぽいです（ソース）。
GitHub PackagesのGradle（Maven）レジストリが良さそう感