Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error::InferenceFailedにsourceとしてOrtErrorを持たせる #668

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 30, 2023

内容

現状ONNX RuntimeのRunが失敗した場合、エラーの内容は破棄されてError::InferenceFailedという情報だけが得られるような状態です。

このPRではONNX RuntimeのエラーをError::InferenceFailedに設定し、COREユーザー側ログ及びENGINEのログでその内容を見られるようにします。

関連 Issue

ref #545

ref #580, #589, #600, #622, #623, #624, #625, #640

その他

@qryxip qryxip mentioned this pull request Oct 30, 2023
69 tasks
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

まあもしかしたらあまり出てほしくないようなエラーメッセージが出てしまうかもしれませんが、そんな致命的なのは出ない気がするので良いかなと・・・!

@Hiroshiba Hiroshiba merged commit c1bd227 into VOICEVOX:main Oct 30, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants