Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.15] .onnx/.binファイルの読み込みを遅延させる #768

Merged
merged 1 commit into from
Mar 31, 2024
Merged

[release-0.15] .onnx/.binファイルの読み込みを遅延させる #768

merged 1 commit into from
Mar 31, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Mar 31, 2024

内容

関連 Issue

Resolves #766.

その他

@qryxip
Copy link
Member Author

qryxip commented Mar 31, 2024

generate_api_documentは ❌ のまま放置という方針であるという認識です。
(release-0.15ブランチへのpushでは作動しませんし)

@qryxip qryxip requested a review from Hiroshiba March 31, 2024 05:36
Hiroshiba
Hiroshiba approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

すごい綺麗な差分だ！！！ありがとうございます！！！！
もしなにか上手く行かなかったらissue建てます！いけそうだったらプルリク作ります。

@Hiroshiba Hiroshiba merged commit fe8358b into VOICEVOX:release-0.15 Mar 31, 2024
36 of 37 checks passed
@qryxip qryxip mentioned this pull request May 4, 2024
Merged
@qryxip qryxip mentioned this pull request Sep 7, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba