Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: InferenceDomainMapValuesのインスタンスをマクロで作る #852

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 9, 2024

内容

#737 に向け。また #851 の後にdecode.onnx入りのVVMに対応するときも同様に役に立つはず。

関連 Issue

#737

その他

#851 とはコンフリクトしないはず。多分。

@qryxip qryxip requested a review from Hiroshiba October 9, 2024 16:25
 VOICEVOX#737 に向け。また VOICEVOX#851 の後にdecode.onnx入りのVVMに対応するときも同様に
役に立つはず。
@qryxip qryxip force-pushed the refactor-impl-inference-domain-map-values-with-macro branch from eb5575d to db228b1 Compare October 9, 2024 16:41
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

ぶっちゃけよくわかんなかったんですが、InferenceDomainを増やしやすくする感じだなという雰囲気は直感できました!!
exampleありがたみ。

@qryxip qryxip merged commit 991fbc8 into VOICEVOX:main Oct 10, 2024
35 checks passed
@qryxip qryxip deleted the refactor-impl-inference-domain-map-values-with-macro branch October 10, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants