-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: length 無音付加のCoreAdapter
移植
#1001
Merged
Hiroshiba
merged 2 commits into
VOICEVOX:master
from
tarepan:refactor/length_pau_adapter
Jan 9, 2024
Merged
整理: length 無音付加のCoreAdapter
移植
#1001
Hiroshiba
merged 2 commits into
VOICEVOX:master
from
tarepan:refactor/length_pau_adapter
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!
self.initialize_style_id_synthesis(style_id, skip_reinit=True) | ||
|
||
# 前後無音を付加する(詳細: voicevox_engine#924) | ||
phoneme_list_s = np.r_[0, phoneme_list_s, 0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今気づいたのですが、0を足すというよりは、Phoneme.pauのidを足すのが処理として正しそうな気がしました・・・!
core_adapterからPhonemeのimportが微妙であれば、CoreAdapterにidをDIする手もあるかも・・・?
(ちょっと自信ないです 🙇 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
音素長合成の無音付加
CoreAdapter
移植によるリファクタリング#999 同様の移植を音素長合成(
update_length()
)でもおこなった。関連 Issue
#999