Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: length 無音付加のCoreAdapter 移植 #1001

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jan 9, 2024

内容

音素長合成の無音付加CoreAdapter 移植によるリファクタリング

#999 同様の移植を音素長合成(update_length())でもおこなった。

関連 Issue

#999

@tarepan tarepan requested a review from a team as a code owner January 9, 2024 17:09
@tarepan tarepan requested review from y-chan and removed request for a team January 9, 2024 17:09
Copy link

github-actions bot commented Jan 9, 2024

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 511 325 coverage-36%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 94 72 coverage-23%
voicevox_engine/core_adapter.py 60 17 coverage-72%
voicevox_engine/core_initializer.py 59 30 coverage-49%
voicevox_engine/core_wrapper.py 225 159 coverage-29%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 36 8 coverage-78%
voicevox_engine/dev/tts_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 28 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 92 5 coverage-95%
voicevox_engine/metas/Metas.py 34 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 6 coverage-67%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 164 9 coverage-95%
voicevox_engine/morphing.py 71 46 coverage-35%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 13 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 80 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 17 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 34 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 88 1 coverage-99%
voicevox_engine/tts_pipeline/mora_list.py 7 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 146 6 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 177 11 coverage-94%
voicevox_engine/user_dict.py 145 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 35 9 coverage-74%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2288 726 coverage-68%

@Hiroshiba Hiroshiba requested review from Hiroshiba and removed request for y-chan January 9, 2024 21:03
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

self.initialize_style_id_synthesis(style_id, skip_reinit=True)

# 前後無音を付加する(詳細: voicevox_engine#924)
phoneme_list_s = np.r_[0, phoneme_list_s, 0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今気づいたのですが、0を足すというよりは、Phoneme.pauのidを足すのが処理として正しそうな気がしました・・・!

core_adapterからPhonemeのimportが微妙であれば、CoreAdapterにidをDIする手もあるかも・・・?
(ちょっと自信ないです 🙇 )

voicevox_engine/core_adapter.py Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 9bba597 into VOICEVOX:master Jan 9, 2024
3 checks passed
@tarepan tarepan deleted the refactor/length_pau_adapter branch January 17, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants