Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localhostと扱うURLの種類を広くする #1477

Merged
merged 2 commits into from
Nov 1, 2024
Merged

localhostと扱うURLの種類を広くする #1477

merged 2 commits into from
Nov 1, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

サブドメイン付きlocalhost、app://localhostを許容するようにします。
VVVST用。

関連 Issue

（なし）

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner October 30, 2024 22:00
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team October 30, 2024 22:00
@Hiroshiba
Copy link
Member

あっ linterが落ちてそうです！
こちらをお願いできれば！
https://github.com/VOICEVOX/voicevox_engine/blob/master/CONTRIBUTING.md#%E9%9D%99%E7%9A%84%E8%A7%A3%E6%9E%90%E3%82%92%E4%B8%80%E6%8B%AC%E5%AE%9F%E8%A1%8C%E3%81%99%E3%82%8B

Hiroshiba
Hiroshiba approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@Hiroshiba Hiroshiba merged commit 9506de2 into VOICEVOX:master Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenc-nanashi @Hiroshiba