Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

コアをロードするときにログを出すようにする #722

Conversation

Hiroshiba
Copy link
Member

内容

過去のコアのロードが原因で起動が遅くなっていたのですが、原因にたどり着くまでに時間がかかったので、ログを出力するようにしてみました。

その他

ロギング周りに課題がありそうだったので、loggingを使った仕組みに変えてもいいかも。

@Hiroshiba Hiroshiba requested a review from a team as a code owner August 11, 2023 19:53
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team August 11, 2023 19:53
@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 2 1 coverage-50%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 3 1 coverage-67%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/downloadable_library.py 93 5 coverage-95%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 14 coverage-52%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 160 9 coverage-94%
voicevox_engine/mora_list.py 5 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 3 1 coverage-67%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 159 coverage-21%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 59 51 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 11 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 9 2 coverage-78%
voicevox_engine/utility/mutex_utility.py 11 1 coverage-91%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 1518 291 coverage-81%

Copy link
Member

@takana-v takana-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ロギング周りに課題がありそうだったので、loggingを使った仕組みに変えてもいいかも。

そろそろprintから卒業してloggingモジュールに移行したいですね...

@Hiroshiba
Copy link
Member Author

そろそろprintから卒業してloggingモジュールに移行したいですね...

ですね・・・。
あ! もしかしてlogging詳しかったりされますか? 👀
僕は雰囲気だけなんとなく知ってて、たぶんglobalに1つlogger作ってログ吐いて、あとはハンドラー?を設定して〜みたいな感じだと思うのですが、詳しくなく・・・・・ 😇

@Hiroshiba
Copy link
Member Author

問題ないと思うのでマージします!

@Hiroshiba Hiroshiba removed the request for review from y-chan August 18, 2023 14:59
@Hiroshiba Hiroshiba merged commit 31b1bc8 into VOICEVOX:master Aug 18, 2023
3 checks passed
@Hiroshiba Hiroshiba deleted the コアをロードするときにログを出すようにする branch August 18, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants