Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Aug 26, 2023
test/e2e/generate_test_client.py
Outdated
Hiroshiba
commented
Aug 26, 2023
Comment on lines
+6
to
9
| def test_fetch_version_success(client: TestClient): | ||
| response = client.get("/version") | ||
| assert response.status_code == 200 | ||
| assert response.json() == __version__ |
There was a problem hiding this comment.
@stmtk1 こんな感じで、引数でclientを取得できます！
以前のimportするコードとほとんど変わらないかなと･･･！
Coverage ResultResultを開く
|
takana-v
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
自分の環境では、pytestだとrunがimportできずに落ちてしまいました。
（現在のmasterでは動作）
coverage run --omit=test/* -m pytestだときちんと動作しました。
エラーログ
$ pytest
===================================================================================================== test session starts ======================================================================================================
platform win32 -- Python 3.11.3, pytest-6.2.5, py-1.11.0, pluggy-1.2.0
rootdir: C:\Users\takana\Github\voicevox_engine
plugins: anyio-3.7.1
collected 0 items / 1 error
============================================================================================================ ERRORS ============================================================================================================
________________________________________________________________________________________________ ERROR collecting test session _________________________________________________________________________________________________
..\..\.pyenv\pyenv-win\versions\3.11.3\Lib\importlib\__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1206: in _gcd_import
???
<frozen importlib._bootstrap>:1178: in _find_and_load
???
<frozen importlib._bootstrap>:1149: in _find_and_load_unlocked
???
<frozen importlib._bootstrap>:690: in _load_unlocked
???
venv\Lib\site-packages\_pytest\assertion\rewrite.py:170: in exec_module
exec(co, module.__dict__)
test\e2e\conftest.py:5: in <module>
from run import generate_app
E ModuleNotFoundError: No module named 'run'
=================================================================================================== short test summary info ====================================================================================================
ERROR - ModuleNotFoundError: No module named 'run'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
======================================================================================================= 1 error in 0.26s =======================================================================================================
|
@takana-v レビューありがとうございます！！！
pythonはデフォルトで実行ディレクトリをPYTHONPATHに追加しないので 実行ディレクトリをPYTHONPATHに追加する方法として、pyproject.tomlにpythonpathを追加する方法がありそうなのですが、なんかうまく動きませんでした。。 python -m pytestだとpythonの仕様？で自動的に実行ディレクトリがimport対象のパスに追加されるらしいので、とりあえずこの方法をリードミーで案内してみました･･･！ |
y-chan
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
e2eテストのTestClientインスタンスをfixtureにしてみました。
fixtureにする利点はいくつかあります。
後々製品版のコアを使うようにする時などに外部から製品版コアのパスを指定しないといけないのですが、fixtureを使えばpytestに乗っかる形になり、コマンドからオプションを渡すのが便利だったりします。
他にもテスト内の全てのセッションでインスタンスを1つだけ作るのか、テストごとにインスタンスを作成するのかなどを分けたりすることもできるようになるので便利だったりします。
関連 Issue
スクリーンショット・動画など
その他