Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt-get update before install libsnbfile1 #746

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

raa0121
Copy link
Contributor

@raa0121 raa0121 commented Sep 15, 2023

内容

libsnbfile1 のインストール前に apt-get update するように

From: https://discord.com/channels/879570910208733277/893889888208977960/1152114292351578224

@raa0121 raa0121 requested a review from a team as a code owner September 15, 2023 05:48
@raa0121 raa0121 requested review from Hiroshiba and removed request for a team September 15, 2023 05:48
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 433 285 coverage-34%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/cancellable_engine.py 85 66 coverage-22%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 27 12 coverage-56%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/downloadable_library.py 93 5 coverage-95%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 12 coverage-59%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 160 9 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/morphing.py 70 46 coverage-34%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 146 coverage-27%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 59 30 coverage-49%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 11 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 2178 659 coverage-70%

@Hiroshiba
Copy link
Member

Hiroshiba commented Sep 15, 2023

PRありがとうございます!

upload-gh-pages.ymlにも同じ問題がありそうでした。

run: sudo apt-get install libsndfile1

また同じことをするコードが既存でありそうでした。書き方をこれに合わせておくとなんとなく安心かもです。

        run: |
          sudo apt-get update
          sudo apt-get install libsndfile1

ご面倒であればこちらで変更&マージさせていただこうかなと!

@raa0121
Copy link
Contributor Author

raa0121 commented Sep 15, 2023

書き方をこれに合わせておくとなんとなく安心かもです。

対応しておきます。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

素早い対応ありがとうございます!!!

@Hiroshiba Hiroshiba merged commit c03fac5 into VOICEVOX:master Sep 15, 2023
3 checks passed
@raa0121 raa0121 deleted the patch-1 branch September 15, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants