Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: 前後空白挿入の統合 #814

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Dec 5, 2023

内容

_synthesis_impl における前後無音挿入の統合

  • calc_frame_per_phoneme() における無音音素の挿入
  • calc_frame_pitch() における前後 f0=0 挿入

をモーラ時系列への無音モーラ付加により統合。

関連 Issue

part of #801

@tarepan tarepan requested a review from a team as a code owner December 5, 2023 06:01
@tarepan tarepan requested review from Hiroshiba and removed request for a team December 5, 2023 06:01
Copy link

github-actions bot commented Dec 5, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 480 326 coverage-32%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 23 1 coverage-96%
voicevox_engine/cancellable_engine.py 91 71 coverage-22%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 27 12 coverage-56%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 38 2 coverage-95%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/library_manager.py 93 5 coverage-95%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 12 coverage-59%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 162 9 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/morphing.py 70 46 coverage-34%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 202 147 coverage-27%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 59 30 coverage-49%
voicevox_engine/synthesis_engine/synthesis_engine.py 139 13 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 71 10 coverage-86%
voicevox_engine/user_dict.py 144 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 2197 711 coverage-68%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼlgtmです!!!

ちょっといくつか名称の提案などをしてみました。
もし気に入ったのがあれば・・・!

voicevox_engine/synthesis_engine/synthesis_engine.py Outdated Show resolved Hide resolved
voicevox_engine/synthesis_engine/synthesis_engine.py Outdated Show resolved Hide resolved
voicevox_engine/synthesis_engine/synthesis_engine.py Outdated Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented Dec 5, 2023

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-reviewよろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!
(見逃しがありました、すみません 🙇 )

ちょっと提案です!
例えば頂いたPRの場合、コメントで提案しつつ、こちらで時系列に、" "" "にしちゃってマージさせていただくと、お互い1回アクションが減りそうだなと感じました。
これくらいの細かさであればこちらで変更・マージさせていただくのはいかがでしょうか 👀

voicevox_engine/synthesis_engine/synthesis_engine.py Outdated Show resolved Hide resolved
voicevox_engine/synthesis_engine/synthesis_engine.py Outdated Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented Dec 5, 2023

こちらで変更・マージ

👍

@Hiroshiba
Copy link
Member

変更したのでマージします!ありがとうございました!!

@Hiroshiba Hiroshiba merged commit 26e14f8 into VOICEVOX:master Dec 6, 2023
3 checks passed
@tarepan tarepan deleted the refactor/sil branch December 6, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants