Migrate: Java APIを使うように #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
commented
Oct 27, 2023
Comment on lines
-44
to
-45
| # generated speakerInfo.json | ||
| public/speakerInfos.json |
There was a problem hiding this comment.
jsonファイルが大きくなりすぎて（51MB近く）大変なことになってたので分割。
Comment on lines
-7
to
-12
| externalNativeBuild { | ||
| cmake { | ||
| path file('src/main/cpp/CMakeLists.txt') | ||
| version '3.22.1' | ||
| } | ||
| } |
| call.resolve(ret) | ||
| } | ||
|
|
||
| @PluginMethod | ||
| fun getSupportedDevicesJson(call: PluginCall) { | ||
| val ret = JSObject() | ||
| ret.put("value", core!!.voicevoxGetSupportedDevicesJson()) | ||
| // TODO: ハードコードをやめてちゃんと取得する | ||
| ret.put("value", "{\"cpu\": true, \"cuda\": false, \"dml\": false}") |
There was a problem hiding this comment.
ここら辺はあとでCoreにPR出します。
Hiroshiba
reviewed
Oct 27, 2023
Hiroshiba
reviewed
Oct 27, 2023
sevenc-nanashi
commented
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Voicevox CoreのJava APIを使うようにします。
また、それに伴って、色々な部分を実際のアセットに置き換えます。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）