Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major upgrade #110

Draft
wants to merge 66 commits into
base: main
Choose a base branch
from
Draft

Major upgrade #110

wants to merge 66 commits into from

Conversation

Kipjr
Copy link
Member

@Kipjr Kipjr commented Dec 10, 2023

No description provided.

Kipjr added 30 commits July 8, 2023 18:25
@Kipjr
Add files via upload
3635851
@Kipjr
Create docker-publish.yml
80cfaad
@Kipjr
Create laravel.yml
ba7b655
@Kipjr
Create DOCKER.md
b745c85
@Kipjr
Create docker-compose.yml
da3ab65
@Kipjr
Update docker-publish.yml
95f0884
@Kipjr
Remove "new" info
16d6f3d
@Kipjr
Rewrite docker-compose.yml
330a750
@Kipjr
Install sail
f051517
@Kipjr
Force HTTPS
6ee7445
@Kipjr
Fix: Trusted Proxies (Upgrade 8->9)
cec7747
@Kipjr
Fix exception handler
cde9759
@Kipjr
Upgrade laravel from 6->10
d0138fc
@Kipjr
Fix class naming issue
f5d64bb
@Kipjr
remove yarn
354e40c
@Kipjr
Fix badges
f050438
@Kipjr
Implement changes of laravel/laravel@6.x...10.x
ae00a68
@Kipjr
Fix: missing middleware
fa2db91
@Kipjr
Fix: primairy id
fa9156a
@Kipjr
Fix: new style routing
8b5b3f9
@Kipjr
Fix: inconsistencies with mensaId and Id
83ab12c
@Kipjr
Fix: missing mensaId / id
a92f596
@Kipjr
Fix mensaId / id
c4f4efd
@Kipjr
Update UserFactory.php
1afe2d2
@Kipjr
I hate spaces
e84d77f
@Kipjr
update composer
a22c257
@Kipjr
Update docker-publish.yml
54dea60 
require sail
@Kipjr
Update laravel.yml
20b66e9
@Kipjr
Update laravel.yml with db location
4d75a06
@Kipjr
Seed db
531273e
@Kipjr
Add signin page
1eeb4e9
@Kipjr
remove ldap config
400bba6
@Kipjr
Add MS Graph delegated User functions
9c944dd
@Kipjr
Add MS Graph application daemon functions
69727a8
@Kipjr
Rewrite LdapHelper to AzureHelper
c88bc19
@Kipjr
Rewrite logincontroller
c100376
@Kipjr
Rename LdapFunction to AzureFunction
55913d1
@Kipjr
Rename more LdapFunctions to AzureFunctions
90e52b3
@Kipjr
Remove old logincontroller
78b2808
@Kipjr
update .env.example
dec7503
@Kipjr
Dont forget the ;
5277677
@Kipjr
Fix query issues
446051e
@Kipjr
Merge pull request #106 from VSLCatena/main-docker
13b3031 
[main] Update framework to version 10
@Kipjr
Merge pull request #109 from VSLCatena/Ldap2Azure
70c109a 
[main] Rewite Ldap to Azure
@Kipjr
add SAIL_VERSION
d3d85e4
@Kipjr
add new image loc
c0d05f1
@Kipjr
Add sail publish
892cd30
@Kipjr
Fix: one specific inage
69facb7
@Kipjr
Fix version in sail
43c123e
@Kipjr
move .env to config
fd8d3a2
@Kipjr
Fix publish
16eb818
@Kipjr
fix build
861a1b8
@Kipjr
fix sail version
7a5a349
Jannyboy313
Jannyboy313 requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@Jannyboy313 Jannyboy313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waarom zijn er 3 workflows aangemaakt, heeft dit met lokaal test en prod te maken, want dan is het handig die namen te geven.?

  • Docker publish
  • Laravel
  • Sail publish

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
app/Exceptions/Handler.php Show resolved Hide resolved
app/Helpers/MSGraphAPI/User.php Show resolved Hide resolved
database/migrations/2014_10_12_000000_create_users_table.php Show resolved Hide resolved
database/migrations/2014_10_12_000000_create_users_table.php Show resolved Hide resolved
docs/DOCKER.md Show resolved Hide resolved
docs/DOCKER.md Show resolved Hide resolved
tests/Feature/BaseURLRequestTest.php Outdated Show resolved Hide resolved
@Kipjr
Copy link
Member Author

Kipjr commented Dec 11, 2023

Waarom zijn er 3 workflows aangemaakt, heeft dit met lokaal test en prod te maken, want dan is het handig die namen te geven.?

* Docker publish

* Laravel

* Sail publish

Laravel is het testen van de applicatie

Sail publish & docker publish zijn hetzelfde, denk ik

@Jannyboy313
Copy link
Contributor

Waarom zijn er 3 workflows aangemaakt, heeft dit met lokaal test en prod te maken, want dan is het handig die namen te geven.?

* Docker publish

* Laravel

* Sail publish

Laravel is het testen van de applicatie

Sail publish & docker publish zijn hetzelfde, denk ik

Als het hetzelfde is een van de twee eruit halen, of in ieder geval duidelijke naam van de action die het doet.

@Kipjr Kipjr marked this pull request as draft January 20, 2024 12:32
@Jannyboy313 Jannyboy313 mentioned this pull request Jan 22, 2024
Open
Kipjr added a commit that referenced this pull request Jan 27, 2024
@Kipjr
Fix error handling based on discussion
bb246d4 
#110 (comment)
Kipjr added a commit that referenced this pull request Jun 22, 2024
@Kipjr
Fix error handling based on discussion
66788a4 
#110 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jannyboy313 Jannyboy313 Jannyboy313 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kipjr @Jannyboy313