chore(feature): removes unused tmpl func (opendatahub-io#1105)

ReplaceChar is not used anywhere in the templates, so there is no point
in keeping it around.

Most likely spill over from infamous opendatahub-io#605.

(cherry picked from commit 0c363cf)

pkg/feature/manifest.go

@@ -82,7 +82,6 @@ func (t *templateManifest) Process(data any) ([]*unstructured.Unstructured, erro
 
 	tmpl, parseErr := template.New(t.name).
 		Option("missingkey=error").
-		Funcs(template.FuncMap{"ReplaceChar": ReplaceChar}).
 		Parse(string(content))
 	if parseErr != nil {
 		return nil, fmt.Errorf("failed to parse template %s: %w", t.path, parseErr)

pkg/feature/types.go

@@ -1,8 +1,6 @@
 package feature
 
 import (
-	"strings"
-
 	featurev1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/features/v1"
 	infrav1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/infrastructure/v1"
 )
@@ -28,7 +26,3 @@ type OAuth struct {
 	ClientSecret,
 	Hmac string
 }
-
-func ReplaceChar(s string, oldChar, newChar string) string {
-	return strings.ReplaceAll(s, oldChar, newChar)
-}