Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component(dashboard): initialize images at startup, remove devflags logging setup #17

Closed
wants to merge 1 commit into from
Closed

component(dashboard): initialize images at startup, remove devflags logging setup #17

wants to merge 1 commit into from

Conversation

lburgazzoli
Copy link

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (initialize_api@59edbbf). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...atasciencecluster/datasciencecluster_controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                Coverage Diff                @@
##             initialize_api      #17   +/-   ##
=================================================
  Coverage                  ?   20.02%           
=================================================
  Files                     ?       32           
  Lines                     ?     3430           
  Branches                  ?        0           
=================================================
  Hits                      ?      687           
  Misses                    ?     2676           
  Partials                  ?       67

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ykaliuta
ykaliuta reviewed Oct 18, 2024
View reviewed changes
controllers/components/dashboard/dashboard_controller.go
@@ -108,7 +107,26 @@ func NewDashboardReconciler(ctx context.Context, mgr ctrl.Manager) error {
return nil
}

func CreateDashboardInstance(dsc *dscv1.DataScienceCluster) *componentsv1.Dashboard {
func Init(platform cluster.Platform) error {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to remove contextual logger as it is done now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mh, were we supposed to ignore the error and just log it ? right now it would cause the operator to fail to start

Copy link

@ykaliuta ykaliuta Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mh, were we supposed to ignore the error and just log it ? right now it would cause the operator to fail to start

I'm talking about fmt.Printf Oops, it's return of error :)

@lburgazzoli lburgazzoli deleted the init branch October 18, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykaliuta ykaliuta ykaliuta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lburgazzoli @codecov-commenter @ykaliuta @VaishnaviHire