Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize and deserialze sessions with email and userType #804

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonm1
Copy link
Member

@leonm1 leonm1 commented Mar 4, 2021

Fixes #522 by only serializing email and userType to DB.

I'm not sure if it'd be even better if we made it query all three hacker + organizer + sponsor models, as that way a log-out wouldn't be required when switching user types, but I feel this problem is better fixed in the user interface overhaul.

@leonm1 leonm1 requested a review from gfting March 4, 2021 12:01
@leonm1 leonm1 enabled auto-merge (squash) March 4, 2021 12:01
Copy link
Member

@gfting gfting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing this!

@github-actions github-actions bot added the approved Automatically added, do not manually add label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Automatically added, do not manually add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passport session lacks a serializer and deserializer
2 participants