Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2848] Set TwoKinksInterestRateModel in the vBNB market #523

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

web3rover
Copy link
Collaborator

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 8, 2024

Code Coverage

Package Line Rate Branch Rate Health
contracts 100% 100%
contracts.Admin 88% 41%
contracts.Comptroller 100% 90%
contracts.Comptroller.Diamond 95% 61%
contracts.Comptroller.Diamond.facets 76% 64%
contracts.Comptroller.Diamond.interfaces 100% 100%
contracts.DelegateBorrowers 100% 89%
contracts.Governance 68% 45%
contracts.InterestRateModels 74% 59%
contracts.Lens 45% 37%
contracts.Liquidator 83% 60%
contracts.Oracle 100% 100%
contracts.PegStability 88% 84%
contracts.Swap 90% 58%
contracts.Swap.interfaces 100% 100%
contracts.Swap.lib 81% 55%
contracts.Tokens 100% 100%
contracts.Tokens.Prime 96% 72%
contracts.Tokens.Prime.Interfaces 100% 100%
contracts.Tokens.Prime.libs 90% 76%
contracts.Tokens.VAI 81% 53%
contracts.Tokens.VRT 20% 9%
contracts.Tokens.VTokens 64% 47%
contracts.Tokens.VTokens.legacy 0% 0%
contracts.Tokens.XVS 19% 8%
contracts.Utils 50% 30%
contracts.VAIVault 50% 45%
contracts.VRTVault 49% 36%
contracts.XVSVault 64% 50%
contracts.lib 89% 71%
Summary 62% (3354 / 5369) 46% (1246 / 2736)

Copy link
Collaborator

@kkirka kkirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder if we could come up with some unified spec format for all markets so that we don't have scripts dedicated specifically for "InterestRateModelVBNB". I think it's out of the scope of this PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants