Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new flow used in Authentik #1350

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

mokrinsky
Copy link
Contributor

Authentik introduced the new authentication flow in this PR: goauthentik/authentik#10296. Basically the change is they switched from using type field to just using different component fields for different operations in the flow.

This PR addresses these changes. Now saml2aws works with recent Authentik version (2024.8.3 at a time), but considering I kept tests for previous flow and they still pass, it should work with older Authentik versions as well.

P.S. I'm not that proficient golang developer, so I would appreciate any suggestions, if any.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.01%. Comparing base (99d6fe4) to head (3d2422d).
Report is 97 commits behind head on master.

Files with missing lines Patch % Lines
pkg/provider/authentik/authentik.go 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1350       +/-   ##
===========================================
- Coverage   42.19%   29.01%   -13.18%     
===========================================
  Files          54       70       +16     
  Lines        6456     9667     +3211     
===========================================
+ Hits         2724     2805       +81     
- Misses       3283     6391     +3108     
- Partials      449      471       +22     
Flag Coverage Δ
unittests 29.01% <83.33%> (-13.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mapkon mapkon merged commit b356b40 into Versent:master Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants