Include use_helpers in all components
#1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reeganviljoen
changed the title
use_helpers in all components
reeganviljoen
force-pushed
the
rv-add-explicit-helpers-by-default
branch
from
a6e1386 to
adc1429
Compare
reeganviljoen
requested review from
BlakeWilliams,
camertron,
joelhawksley,
Spone and
boardfish
boardfish
reviewed
Jan 22, 2024
joelhawksley
approved these changes
Jan 22, 2024
Co-authored-by: Joel Hawksley <[email protected]>
Co-authored-by: Joel Hawksley <[email protected]>
Co-authored-by: Joel Hawksley <[email protected]>
|
@joelhawksley I have applied you changes, thank you 🙏 |
Spone
reviewed
Jan 24, 2024
Co-authored-by: Joel Hawksley <[email protected]>
|
@joelhawksley, @Spone , @boardfish any updates ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In order to complete #1976 the
#use_helpersmethod needs to be added to components by default, so this pr is part of a two part series, hopefully this can bee included with version 4